Search
j0ke.net Open Build Service
>
Projects
>
server:monitoring
>
perl-Data-Random
> perl-Data-Random-0.05-Check-if-_to_secs-returns-undef.patch
Sign Up
|
Log In
Username
Password
Cancel
Overview
Repositories
Revisions
Requests
Users
Advanced
Attributes
Meta
File perl-Data-Random-0.05-Check-if-_to_secs-returns-undef.patch of Package perl-Data-Random
From 7dcdfa9edfc632609b3fc99aabb46a40b0083875 Mon Sep 17 00:00:00 2001 From: Niko Tyni <ntyni@iki.fi> Date: Fri, 17 Dec 2010 10:35:33 +0100 Subject: [PATCH] Check if _to_secs() returns undef t/rand_time.t fails when rand_time() returns "00:00:00", since _to_secs() then returns 0 which evaluates to false. This happens with a probability of about 7 % and was found in an automatic build of the Debian packaged version of Data::Random. https://rt.cpan.org/Public/Bug/Display.html?id=27392 --- t/rand_datetime.t | 10 +++++----- t/rand_time.t | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/t/rand_datetime.t b/t/rand_datetime.t index b7a2118..00d8993 100755 --- a/t/rand_datetime.t +++ b/t/rand_datetime.t @@ -35,7 +35,7 @@ SKIP: { $pass = 0 unless $delta >= 0 && $delta <= $max_days - && _to_secs( ( split ( / /, $date ) )[1] ); + && defined( _to_secs( ( split ( / /, $date ) )[1] ) ); $i++; } @@ -59,7 +59,7 @@ SKIP: { $pass = 0 unless $delta >= 0 && $delta <= $max_days - && _to_secs( ( split ( / /, $date ) )[1] ); + && defined( _to_secs( ( split ( / /, $date ) )[1] ) ); $i++; } @@ -89,7 +89,7 @@ SKIP: { $pass = 0 unless $delta >= 0 && $delta <= $max_days - && _to_secs( ( split ( / /, $date ) )[1] ); + && defined( _to_secs( ( split ( / /, $date ) )[1] ) ); $i++; } @@ -121,7 +121,7 @@ SKIP: { $pass = 0 unless $delta >= 0 && $delta <= $max_days - && _to_secs( ( split ( / /, $date ) )[1] ); + && defined( _to_secs( ( split ( / /, $date ) )[1] ) ); $i++; } @@ -139,7 +139,7 @@ SKIP: { $pass = 0 unless $new_year == $year && $new_month == $month && $new_day == $day - && _to_secs( ( split ( / /, $date ) )[1] ); + && defined( _to_secs( ( split ( / /, $date ) )[1] ) ); ok($pass); } diff --git a/t/rand_time.t b/t/rand_time.t index 1f9b656..3592c7e 100755 --- a/t/rand_time.t +++ b/t/rand_time.t @@ -16,7 +16,7 @@ use Data::Random qw( rand_time ); while ( $pass && $i < $max_secs ) { my $time = rand_time(); - $pass = 0 unless _to_secs($time); + $pass = 0 unless defined( _to_secs($time) ); $i++; } -- 1.7.3.3