Changes of Revision 2
[-] | Changed | amarok.spec |
x 1
2 # 3 # spec file for package amarok 4 # 5 -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. 6 +# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. 7 # 8 # All modifications and additions to the file contributed by third parties 9 # remain the property of their copyright owners, unless otherwise agreed 10
11 # Please submit bugfixes or comments via http://bugs.opensuse.org/ 12 # 13 14 -# norootforbuild 15 16 %bcond_with ffmpeg 17 18 Name: amarok 19 -Version: 2.4.3 20 -Release: 17.4 21 +Version: 2.6.0 22 +Release: 6.1 23 Summary: Media Player for KDE 24 +License: GPL-2.0+ 25 +Group: Productivity/Multimedia/Sound/Players 26 27 -License: GPLv2+ 28 Url: http://amarok.kde.org/ 29 -Group: Productivity/Multimedia/Sound/Players 30 -Source0: ftp://ftp.kde.org/pub/kde/stable/amarok/%{version}/src/%{name}-%{version}.tar.bz2 31 -# PATCH-FIX-OPENSUSE errmsg-mysql51-embedded.diff -- Don't require errmsg.sys from mysql package 32 -Patch0: errmsg-mysql51-embedded.diff 33 -# PATCH-FEATURE-OPENSUSE ksuseinstall.diff llunak@novell.com -- Support for on-demand codecs install using ksuseinstall 34 -Patch1: ksuseinstall.diff 35 +Source0: ftp://ftp.kde.org/pub/kde/stable/%{name}/%{version}/src/%{name}-%{version}.tar.bz2 36 # PATCH-FIX-OPENSUSE initial-preference.diff bnc#605522 llunak@novell.com -- Increase initial preference to be used for audio files instead of Kaffeine 37 -Patch2: initial-preference.diff 38 +Patch1: initial-preference.diff 39 # PATCH-FIX-OPENSUSE flac_mimetype_bnc671581.diff bnc#671581 ctrippe@gmx.net -- Support for the changed mimetype for flac files 40 -Patch3: flac_mimetype_bnc671581.diff 41 +Patch2: flac_mimetype_bnc671581.diff 42 +Patch3: revert_solid_workaround.diff 43 BuildRoot: %{_tmppath}/%{name}-%{version}-build 44 45 # Required for the fdupes macro 46 BuildRequires: fdupes 47 -%if 0%{?suse_version} == 1130 48 -BuildRequires: gtk2-devel 49 -%else 50 BuildRequires: gdk-pixbuf-devel 51 -%endif 52 BuildRequires: glib2-devel 53 BuildRequires: libcurl-devel 54 %if %{with ffmpeg} 55
56 %endif 57 BuildRequires: libgcrypt-devel 58 BuildRequires: libgpod-devel >= 0.7.0 59 -BuildRequires: libkde4-devel 60 +BuildRequires: libkde4-devel >= 4.6.0 61 BuildRequires: libksuseinstall-devel 62 BuildRequires: liblastfm-devel 63 BuildRequires: libmtp-devel 64 -BuildRequires: libmygpo-qt-devel 65 +BuildRequires: libmygpo-qt-devel >= 1.0.5 66 BuildRequires: libmysqlclient-devel 67 BuildRequires: libmysqld-devel 68 BuildRequires: libopenssl-devel 69 BuildRequires: libqca2-devel 70 BuildRequires: libqjson-devel 71 BuildRequires: loudmouth-devel 72 -BuildRequires: mysql 73 BuildRequires: qt4-qtscript 74 -BuildRequires: taglib-devel 75 +BuildRequires: libtag-devel 76 BuildRequires: taglib-extras-devel 77 BuildRequires: tcpd-devel 78 %if 0%{?suse_version} 79 BuildRequires: update-desktop-files 80 %endif 81 Requires: libtag-extras1 >= 1.0 82 -Requires: qt4-qtscript 83 Requires: taglib >= 1.6 84 %kde4_runtime_requires 85 Recommends: moodbar 86 +Recommends: qt4-qtscript 87 Recommends: %{name}-lang = %{version} 88 Provides: kde4-amarok = 2.0.90 89 Obsoletes: kde4-amarok <= 2.0.89 90
91 %lang_package 92 %prep 93 %setup -q 94 -%patch0 95 -%if !0%{?kde_updatedapps} 96 -%patch1 -p1 97 -%endif 98 +%patch1 99 %patch2 100 -%if 0%{?suse_version} > 1130 101 -%patch3 102 -%endif 103 +%patch3 -p1 104 105 # Remove build time references so build-compare can do its work 106 FAKE_BUILDDATE=$(LC_ALL=C date -u -r %{_sourcedir}/%{name}.changes '+%%b %%e %%Y') 107
108 %kde4_makeinstall 109 cd .. 110 111 -# bnc#509815 -- Don't require errmsg.sys from mysql package 112 -install -pm 0644 %{_datadir}/mysql/english/errmsg.sys %{buildroot}%{_kde4_appsdir}/amarok/errmsg.sys 113 - 114 # Remove *.so files (not needed), fix "devel-file-in-non-devel-package" rpmlint warning 115 # "libampache_account_login.so" should not be removed 116 rm -f %{buildroot}%{_kde4_libdir}/libamarok{core,lib,ocsclient,pud,-sqlcollection,-transcoding}.so 117 118 +#bnc722284 amarok is not really a good player for audio-cds, remove the action for solid 119 +rm -f %{buildroot}%{_kde4_appsdir}/solid/actions/amarok-play-audiocd.desktop 120 + 121 %if 0%{?suse_version} 122 %suse_update_desktop_file amarok Qt KDE AudioVideo Audio Player 123 %endif 124
125 126 %postun -p /sbin/ldconfig 127 128 -%clean 129 -rm -rf %{buildroot} 130 - 131 %files 132 %defattr(-,root,root,-) 133 %doc AUTHORS COPYING* ChangeLog README TODO 134
135 %{_kde4_iconsdir}/hicolor/*/apps/amarok.* 136 %{_kde4_appsdir}/amarok/ 137 %dir %{_kde4_appsdir}/desktoptheme 138 -%{_kde4_appsdir}/desktoptheme/Amarok-Mockup/ 139 %dir %{_kde4_appsdir}/desktoptheme/default 140 %dir %{_kde4_appsdir}/desktoptheme/default/widgets 141 %{_kde4_appsdir}/desktoptheme/default/widgets/amarok-* 142 %{_kde4_appsdir}/kconf_update/amarok-2.4.1-tokens_syntax_update.pl 143 %{_kde4_appsdir}/kconf_update/amarok.upd 144 -%dir %{_kde4_appsdir}/solid 145 -%dir %{_kde4_appsdir}/solid/actions 146 -%{_kde4_appsdir}/solid/actions/amarok-play-audiocd.desktop 147 %{_kde4_sharedir}/config.kcfg/amarokconfig.kcfg 148 %{_kde4_configdir}/amarok* 149 %{_kde4_servicesdir}/ServiceMenus/amarok_append.desktop 150
151 %exclude %{_kde4_htmldir}/en/amarok/ 152 153 %changelog 154 -* Mon Aug 29 2011 idonmez@suse.com 155 -- Don't disable ksuseintall & liblastfm support for KDE:UpdatedApps 156 -* Tue Aug 9 2011 reddwarf@opensuse.org 157 -- Optionally enable MusicDNS support (requires ffmpeg/libav) 158 -* Mon Aug 1 2011 asterios.dramis@gmail.com 159 -- Update to 2.4.3: 160 - Bugfixes: 161 - * Fix KWallet auth requests on every track change. (bko#278177) 162 - * Display correct values for pretty times (playlist length) > 1 day. 163 - * Update playlist length correctly after removing track. (bko#273407) 164 - * Fix seek backward from dbus. (Thanks to Matthieu Bedouet) (bko#263287) 165 - * Prevent dialog querying last.fm settings being displayed on startup if 166 - none set. 167 - * Fix detection of smartphones in USB storage mode. (bko#277685) 168 - * Fix crashes on expanding a newly cloned dynamic playlist (bko#277750) 169 - * Don't block the UI while calculating the filename previews. (bko#233196) 170 - * Make M3U & PLS playlist files editable from Saved Playlists. (bko#245963) 171 - From 2.4.2-Beta 1: 172 - Features: 173 - * Made Amarok compile with the Clang LLVM frontend. 174 - * Enable drag and drop on collections to copy/move within Local Music and 175 - directly from the playlist. (bko#223400) 176 - * Added KNotify scripting interface. (bko#260750) 177 - * Make podcast episodes download filename configurable. Patch by 178 - Sandeep Raghuraman. (bko#155075) 179 - * Automatic scrolling in lyrics applet (Thanks to Jan Gerrit Marker) 180 - * Option to scrobble composer as artist to Last.fm (Thanks to Nicholas 181 - Wilson) 182 - * Option to hide the OSD if another window is taking the full screen 183 - Changes: 184 - * Again write back ratings only if option is selected. 185 - * Moved the queue-editor action to the main menu under playlist to save 186 - space. Queue editor now has a shortcut: Meta+U. 187 - * Removed the redo action from the playlist toolbar to make it less wide. 188 - * Made some playlist toolbar actions collapse into a menu button for use on 189 - small screens. 190 - * Removed the statusbar. Moved progress info & messages to the Media 191 - Sources dock. 192 - * Removed the preview button and checkbox from the organize collection 193 - dialog. 194 - * General user interface cleanup (addition of browser widget backgrounds, 195 - etc.) 196 - * Removed the add button in the context toolbar. Applet explorer is opened 197 - on config. 198 - * Easier to understand Dynamic playlists 199 - * Made Amarok depend ffmpeg-0.6 or newer. 200 - * Use KImageCache if possible (kdelibs 4.5.0 and later), which should 201 |
||
[+] | Deleted | errmsg-mysql51-embedded.diff ^ |
@@ -1,17 +0,0 @@ ---- src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp -+++ src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp -@@ -64,12 +64,12 @@ MySqlEmbeddedStorage::MySqlEmbeddedStorage( const QString &storageLocation ) - // CAUTION: if we ever change the table type we will need to fix a number of MYISAM specific - // functions, such as FULLTEXT indexing. - out << "default-storage-engine = MyISAM" << endl; -- out << "loose-innodb = 0" << endl; -+ out << "language=/usr/share/kde4/apps/amarok" << endl; - out << "skip-grant-tables = 1" << endl; - out << "myisam-recover = FORCE" << endl; - out << "key_buffer_size = 16777216" << endl; // (16Mb) - out << "character-set-server = utf8" << endl; -- out << "collation-server = utf8_bin" << endl; -+ out << "collation-server = utf8_unicode_ci" << endl; - //If the file is world-writable MySQL won't even read it - df.setPermissions( QFile::ReadOwner | QFile::WriteOwner | QFile::ReadGroup | QFile::ReadOther ); - df.close(); | ||
[+] | Changed | flac_mimetype_bnc671581.diff ^ |
@@ -1,6 +1,8 @@ ---- src/amarok.desktop 2011-01-11 16:58:05.000000000 +0100 -+++ src/amarok.desktop_patched 2011-02-15 21:44:08.000000000 +0100 -@@ -176,7 +176,7 @@ +Index: src/amarok.desktop +=================================================================== +--- src/amarok.desktop.orig ++++ src/amarok.desktop +@@ -184,7 +184,7 @@ Comment[zh_TW]=Amarok - 重新探索您 Icon=amarok # Add pure audio formats here, for other formats see amarok_*.desktop files # See bug 242292 @@ -8,4 +10,4 @@ +MimeType=audio/aac;audio/mp4;audio/mpeg;audio/mpegurl;audio/vnd.rn-realaudio;audio/vorbis;audio/flac;audio/x-mp3;audio/x-mpegurl;audio/x-ms-wma;audio/x-musepack;audio/x-oggflac;audio/x-pn-realaudio;audio/x-scpls;audio/x-speex;audio/x-vorbis;audio/x-wav;application/x-ogm-audio;audio/x-vorbis+ogg;audio/ogg; X-DocPath=amarok/index.html X-KDE-Keywords=music,podcast - X-KDE-Protocols=http + X-KDE-Keywords[ca]=música,podcast | ||
[+] | Changed | initial-preference.diff ^ |
@@ -2,9 +2,9 @@ =================================================================== --- src/amarok.desktop.orig +++ src/amarok.desktop -@@ -180,5 +180,6 @@ MimeType=audio/aac;audio/mp4;audio/mpeg; - X-DocPath=amarok/index.html - X-KDE-Keywords=music,podcast +@@ -196,5 +196,6 @@ X-KDE-Keywords[uk]=music,podcast,мÑзР+ X-KDE-Keywords[x-test]=xxmusic,podcastxx + X-KDE-Keywords[zh_TW]=music,podcast X-KDE-Protocols=http +InitialPreference=5 Terminal=false | ||
[+] | Deleted | ksuseinstall.diff ^ |
@@ -1,74 +0,0 @@ -diff -uNr amarok-2.4.3.orig/src/CMakeLists.txt amarok-2.4.3/src/CMakeLists.txt ---- amarok-2.4.3.orig/src/CMakeLists.txt 2011-07-28 16:04:45.000000000 +0300 -+++ amarok-2.4.3/src/CMakeLists.txt 2011-08-01 20:24:43.751000029 +0300 -@@ -918,6 +918,7 @@ - amarokcore - amarokocsclient - amarok-transcoding -+ ksuseinstall - ) - - if( TAGLIB_FOUND ) -diff -uNr amarok-2.4.3.orig/src/EngineController.cpp amarok-2.4.3/src/EngineController.cpp ---- amarok-2.4.3.orig/src/EngineController.cpp 2011-07-28 16:04:45.000000000 +0300 -+++ amarok-2.4.3/src/EngineController.cpp 2011-08-01 20:28:18.760000029 +0300 -@@ -54,6 +54,8 @@ - #include <QTextDocument> - #include <QtCore/qmath.h> - -+#include <ksuseinstall.h> -+ - namespace The { - EngineController* engineController() { return EngineController::instance(); } - } -@@ -280,6 +282,7 @@ - bool - EngineController::installDistroCodec() - { -+#if 0 - KService::List services = KServiceTypeTrader::self()->query( "Amarok/CodecInstall" - , QString( "[X-KDE-Amarok-codec] == 'mp3' and [X-KDE-Amarok-engine] == 'phonon-%1'").arg( "xine" ) ); - //todo - figure out how to query Phonon for the current backend loaded -@@ -289,6 +292,12 @@ - QString installScript = service->exec(); - if( !installScript.isNull() ) //just a sanity check - { -+#else -+ // amarok restart may be required, do not complain repeatedly in such case -+ static bool alreadyDone = false; -+ if( alreadyDone ) -+ return true; -+#endif - KGuiItem installButton( i18n( "Install MP3 Support" ) ); - if(KMessageBox::questionYesNo( The::mainWindow() - , i18n("Amarok currently cannot play MP3 files. Do you want to install support for MP3?") -@@ -297,11 +306,29 @@ - , KStandardGuiItem::no() - , "codecInstallWarning" ) == KMessageBox::Yes ) - { -+#if 0 - KRun::runCommand(installScript, 0); - return true; -+#else -+ if( KSUSEInstall::installCapabilities( QStringList() << "libxine1-codecs", -+ KSUSEInstall::FullInstallRequired, The::mainWindow())) -+ { // TODO use the items -+ KGuiItem restartNowGuiItem( KStandardGuiItem::yes()); -+ restartNowGuiItem.setText( i18nc( "@action:button", "Restart Now" )); -+ KGuiItem restartLaterGuiItem( KStandardGuiItem::no()); -+ restartLaterGuiItem.setText( i18nc( "@action:button", "Restart Later" )); -+ KMessageBox::information( The::mainWindow(), -+ i18n( "The necessary support has been successfully installed." -+ " It may be necessary to restart the application for the support to be activated." )); -+ alreadyDone = true; -+ return true; -+ } -+#endif - } -+#if 0 - } - } -+#endif - - return false; - } | ||
[+] | Added | revert_solid_workaround.diff ^ |
@@ -0,0 +1,83 @@ +diff --git a/src/MediaDeviceCache.cpp b/src/MediaDeviceCache.cpp +index 15583b8..8682f4d 100644 +--- a/src/MediaDeviceCache.cpp ++++ b/src/MediaDeviceCache.cpp +@@ -50,10 +50,10 @@ + { + DEBUG_BLOCK + s_instance = this; +- connect( Solid::DeviceNotifier::instance(), SIGNAL( deviceAdded( const QString & ) ), +- this, SLOT( slotAddSolidDevice( const QString & ) ) ); +- connect( Solid::DeviceNotifier::instance(), SIGNAL( deviceRemoved( const QString & ) ), +- this, SLOT( slotRemoveSolidDevice( const QString & ) ) ); ++ connect( Solid::DeviceNotifier::instance(), SIGNAL( deviceAdded( QString & ) ), ++ this, SLOT( slotAddSolidDevice( QString & ) ) ); ++ connect( Solid::DeviceNotifier::instance(), SIGNAL( deviceRemoved( QString & ) ), ++ this, SLOT( slotRemoveSolidDevice( QString & ) ) ); + } + + MediaDeviceCache::~MediaDeviceCache() +@@ -92,19 +92,17 @@ + { + if( !m_volumes.contains( device.udi() ) ) + { +- connect( ssa, SIGNAL( accessibilityChanged(bool, const QString&) ), +- this, SLOT( slotAccessibilityChanged(bool, const QString&) ) ); ++ connect( ssa, SIGNAL( accessibilityChanged(bool, QString&) ), ++ this, SLOT( slotAccessibilityChanged(bool, QString&) ) ); + m_volumes.append( device.udi() ); + } + if( ssa->isAccessible() ) + { + m_type[device.udi()] = MediaDeviceCache::SolidVolumeType; + m_name[device.udi()] = ssa->filePath(); +- m_accessibility[ device.udi() ] = true; + } + else + { +- m_accessibility[ device.udi() ] = false; + debug() << "Solid device is not accessible, will wait until it is to consider it added."; + } + } +@@ -194,8 +192,8 @@ + debug() << "volume is generic storage"; + if( !m_volumes.contains( device.udi() ) ) + { +- connect( ssa, SIGNAL( accessibilityChanged(bool, const QString&) ), +- this, SLOT( slotAccessibilityChanged(bool, const QString&) ) ); ++ connect( ssa, SIGNAL( accessibilityChanged(bool, QString&) ), ++ this, SLOT( slotAccessibilityChanged(bool, QString&) ) ); + m_volumes.append( device.udi() ); + } + if( ssa->isAccessible() ) +@@ -267,8 +265,8 @@ + Solid::Device device( udi ); + if( m_volumes.contains( udi ) ) + { +- disconnect( device.as<Solid::StorageAccess>(), SIGNAL( accessibilityChanged(bool, const QString&) ), +- this, SLOT( slotAccessibilityChanged(bool, const QString&) ) ); ++ disconnect( device.as<Solid::StorageAccess>(), SIGNAL( accessibilityChanged(bool, QString&) ), ++ this, SLOT( slotAccessibilityChanged(bool, QString&) ) ); + m_volumes.removeAll( udi ); + emit deviceRemoved( udi ); + } +diff --git a/src/MediaDeviceCache.h b/src/MediaDeviceCache.h +index a48d453..0e971cc 100644 +--- a/src/MediaDeviceCache.h ++++ b/src/MediaDeviceCache.h +@@ -23,7 +23,6 @@ + #include <QMap> + #include <QString> + #include <QStringList> +-#include <QtCore/QTimer> + + namespace Solid { + class Device; +@@ -67,7 +66,6 @@ + private: + QMap<QString, MediaDeviceCache::DeviceType> m_type; + QMap<QString, QString> m_name; +- QMap<QString, bool> m_accessibility; + QStringList m_volumes; + static MediaDeviceCache* s_instance; + }; | ||
Changed | amarok-2.6.0.tar.bz2 ^ |